Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1872653002: Plugin element widget may be a RemoteFrameView. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin element widget may be a RemoteFrameView. Corrected ASSERT and re-enabled test. Removed ENABLE(OILPAN) ifdef in the neighborhood since its removal is in progress. R=dcheng@chromium.org,lukasza@chromium.org BUG=601581 Committed: https://crrev.com/b9d69b613d2dbfe770e1b35447c3f957cc515e33 Cr-Commit-Position: refs/heads/master@{#386005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872653002/1
4 years, 8 months ago (2016-04-07 23:18:19 UTC) #2
rune
PTAL. I don't know if RemoteFrameView needs any special treatment, but included it as a ...
4 years, 8 months ago (2016-04-07 23:18:42 UTC) #3
Łukasz Anforowicz
+sigbjornf@ to CC (author of the original assert) LGTM. Could you please set up the ...
4 years, 8 months ago (2016-04-07 23:30:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 02:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872653002/1
4 years, 8 months ago (2016-04-08 06:09:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 06:14:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 06:15:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9d69b613d2dbfe770e1b35447c3f957cc515e33
Cr-Commit-Position: refs/heads/master@{#386005}

Powered by Google App Engine
This is Rietveld 408576698