Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 1872653002: Plugin element widget may be a RemoteFrameView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 5 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 { 79 {
80 visitor->trace(m_imageLoader); 80 visitor->trace(m_imageLoader);
81 visitor->trace(m_persistedPluginWidget); 81 visitor->trace(m_persistedPluginWidget);
82 HTMLFrameOwnerElement::trace(visitor); 82 HTMLFrameOwnerElement::trace(visitor);
83 } 83 }
84 84
85 void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget) 85 void HTMLPlugInElement::setPersistedPluginWidget(Widget* widget)
86 { 86 {
87 if (m_persistedPluginWidget == widget) 87 if (m_persistedPluginWidget == widget)
88 return; 88 return;
89 #if ENABLE(OILPAN)
90 if (m_persistedPluginWidget) { 89 if (m_persistedPluginWidget) {
91 if (m_persistedPluginWidget->isPluginView()) { 90 if (m_persistedPluginWidget->isPluginView()) {
92 m_persistedPluginWidget->hide(); 91 m_persistedPluginWidget->hide();
93 m_persistedPluginWidget->dispose(); 92 m_persistedPluginWidget->dispose();
94 } else { 93 } else {
95 ASSERT(m_persistedPluginWidget->isFrameView()); 94 ASSERT(m_persistedPluginWidget->isFrameView() || m_persistedPluginWi dget->isRemoteFrameView());
96 } 95 }
97 } 96 }
98 #endif
99 m_persistedPluginWidget = widget; 97 m_persistedPluginWidget = widget;
100 } 98 }
101 99
102 bool HTMLPlugInElement::canProcessDrag() const 100 bool HTMLPlugInElement::canProcessDrag() const
103 { 101 {
104 return pluginWidget() && pluginWidget()->isPluginView() && toPluginView(plug inWidget())->canProcessDrag(); 102 return pluginWidget() && pluginWidget()->isPluginView() && toPluginView(plug inWidget())->canProcessDrag();
105 } 103 }
106 104
107 bool HTMLPlugInElement::willRespondToMouseClickEvents() 105 bool HTMLPlugInElement::willRespondToMouseClickEvents()
108 { 106 {
(...skipping 497 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 604
607 void HTMLPlugInElement::lazyReattachIfNeeded() 605 void HTMLPlugInElement::lazyReattachIfNeeded()
608 { 606 {
609 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) { 607 if (!useFallbackContent() && needsWidgetUpdate() && layoutObject() && !isIma geType()) {
610 lazyReattachIfAttached(); 608 lazyReattachIfAttached();
611 setPersistedPluginWidget(nullptr); 609 setPersistedPluginWidget(nullptr);
612 } 610 }
613 } 611 }
614 612
615 } // namespace blink 613 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698