Allow content layer to pass ProtocolInterceptors when we create URLRequestContext

chrome/browser/ui/app_list/test/fake_profile.h

Index: chrome/browser/ui/app_list/test/fake_profile.h
diff --git a/chrome/browser/ui/app_list/test/fake_profile.h b/chrome/browser/ui/app_list/test/fake_profile.h
index d979db0e3d5f87cd2d33a595c8be3aadfc7abc87..615ed6c215654d5950a02856ec2726b98f5210ce 100644
--- a/chrome/browser/ui/app_list/test/fake_profile.h
+++ b/chrome/browser/ui/app_list/test/fake_profile.h
@@ -88,11 +88,13 @@ class FakeProfile : public Profile {
   virtual bool IsSameProfile(Profile* profile) OVERRIDE;
   virtual base::Time GetStartTime() const OVERRIDE;
   virtual net::URLRequestContextGetter* CreateRequestContext(
-      content::ProtocolHandlerMap* protocol_handlers) OVERRIDE;
+      content::ProtocolHandlerMap* protocol_handlers,
+      content::ProtocolHandlerScopedVector protocol_interceptors) OVERRIDE;

[sky, 2014/03/07 17:35:41]

Why aren't you passing a const& here? If receivers need to mutate then it should
be a pointer to a ProtocolHandlerScopedVector 

[sky, 2014/03/07 17:37:12]

Actually, if callers don't need to mutate than a const std::vector<XXX>& would
be better since the Scoped part is really an implementation detail.

[mmenke, 2014/03/07 17:53:51]

This is just like passing a scoped_ptr, only to a vector.  It indicates (And
enforces) that the function takes ownership of the vector, and its contents.

[kinuko, 2014/03/08 03:37:44]

sky@: As Matt wrote I used scoped vector here to indicate the ownership
transfer, i.e. the vector's ownership is to be transferred from caller to
callee.  Neither const& or pointer can indicate it clearer than scoped vector
and I want to keep this signature (for clarity).  Does it make sense to you?

   virtual net::URLRequestContextGetter* CreateRequestContextForStoragePartition(
       const base::FilePath& partition_path,
       bool in_memory,
-      content::ProtocolHandlerMap* protocol_handlers) OVERRIDE;
+      content::ProtocolHandlerMap* protocol_handlers,
+      content::ProtocolHandlerScopedVector protocol_interceptors) OVERRIDE;
   virtual base::FilePath last_selected_directory() OVERRIDE;
   virtual void set_last_selected_directory(const base::FilePath& path) OVERRIDE;