Allow content layer to pass ProtocolInterceptors when we create URLRequestContext

chrome/browser/ui/app_list/test/fake_profile.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_APP_LIST_TEST_FAKE_PROFILE_H_
 #define CHROME_BROWSER_UI_APP_LIST_TEST_FAKE_PROFILE_H_
 
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 70 matching lines @@
   virtual PrefService* GetPrefs() OVERRIDE;
   virtual PrefService* GetOffTheRecordPrefs() OVERRIDE;
   virtual net::URLRequestContextGetter* GetRequestContext() OVERRIDE;
   virtual net::URLRequestContextGetter*
       GetRequestContextForExtensions() OVERRIDE;
   virtual net::SSLConfigService* GetSSLConfigService() OVERRIDE;
   virtual HostContentSettingsMap* GetHostContentSettingsMap() OVERRIDE;
   virtual bool IsSameProfile(Profile* profile) OVERRIDE;
   virtual base::Time GetStartTime() const OVERRIDE;
   virtual net::URLRequestContextGetter* CreateRequestContext(
-      content::ProtocolHandlerMap* protocol_handlers) OVERRIDE;
+      content::ProtocolHandlerMap* protocol_handlers,
+      content::ProtocolHandlerScopedVector protocol_interceptors) OVERRIDE;

[sky, 2014/03/07 17:35:41]

Why aren't you passing a const& here? If receivers need to mutate then it should
be a pointer to a ProtocolHandlerScopedVector 

[sky, 2014/03/07 17:37:12]

Actually, if callers don't need to mutate than a const std::vector<XXX>& would
be better since the Scoped part is really an implementation detail.

[mmenke, 2014/03/07 17:53:51]

This is just like passing a scoped_ptr, only to a vector.  It indicates (And
enforces) that the function takes ownership of the vector, and its contents.

[kinuko, 2014/03/08 03:37:44]

sky@: As Matt wrote I used scoped vector here to indicate the ownership
transfer, i.e. the vector's ownership is to be transferred from caller to
callee.  Neither const& or pointer can indicate it clearer than scoped vector
and I want to keep this signature (for clarity).  Does it make sense to you?

   virtual net::URLRequestContextGetter* CreateRequestContextForStoragePartition(
       const base::FilePath& partition_path,
       bool in_memory,
-      content::ProtocolHandlerMap* protocol_handlers) OVERRIDE;
+      content::ProtocolHandlerMap* protocol_handlers,
+      content::ProtocolHandlerScopedVector protocol_interceptors) OVERRIDE;
   virtual base::FilePath last_selected_directory() OVERRIDE;
   virtual void set_last_selected_directory(const base::FilePath& path) OVERRIDE;
 
 #if defined(OS_CHROMEOS)
   virtual void ChangeAppLocale(
       const std::string& locale, AppLocaleChangedVia via) OVERRIDE;
   virtual void OnLogin() OVERRIDE;
   virtual void InitChromeOSPreferences() OVERRIDE;
 #endif  // defined(OS_CHROMEOS)
 
   virtual PrefProxyConfigTracker* GetProxyConfigTracker() OVERRIDE;
   virtual chrome_browser_net::Predictor* GetNetworkPredictor() OVERRIDE;
   virtual void ClearNetworkingHistorySince(
       base::Time time, const base::Closure& completion) OVERRIDE;
   virtual GURL GetHomePage() OVERRIDE;
   virtual bool WasCreatedByVersionOrLater(const std::string& version) OVERRIDE;
   virtual void SetExitType(ExitType exit_type) OVERRIDE;
   virtual ExitType GetLastSessionExitType() OVERRIDE;
 
  private:
   std::string name_;
   base::FilePath path_;
 };
 
 #endif  // CHROME_BROWSER_UI_APP_LIST_TEST_FAKE_PROFILE_H_