chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc - Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments mentioned by fukino@. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc ('k') | chrome/browser/chromeos/file_manager/file_tasks.h » ('j') | extensions/common/manifest_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

index cde13812e0d2a601ce349220191f9ef4d88f0ff9..4784f6068a839e894319305d6176bdc693b1b3ec 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

@@ -10,6 +10,7 @@

#include <string>

#include <vector>

+#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/chromeos/drive/file_system_util.h"

#include "chrome/browser/chromeos/file_manager/fileapi_util.h"

#include "chrome/browser/chromeos/fileapi/file_system_backend.h"

@@ -197,7 +198,8 @@ void FileManagerPrivateInternalGetFileTasksFunction::

file_manager::file_tasks::TaskDescriptorToId(task.task_descriptor());

if (!task.icon_url().is_empty())

converted.icon_url = task.icon_url().spec();

- converted.title = task.task_title();

+ // TODO(cmihail): Does this conversion really work?

mtomasz 2016/04/13 09:17:06 Please confirm before committing :)

cmihail 2016/04/18 01:28:10 N/A as internationalization moved to JS code.

+ converted.title = base::UTF16ToUTF8(task.task_title());

converted.is_default = task.is_default();

converted.is_generic_file_handler = task.is_generic_file_handler();

results.push_back(std::move(converted));