extensions/common/manifest_constants.cc - Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_constants.cc

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments mentioned by fukino@. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc ('K') | « extensions/common/manifest_constants.h ('k') | extensions/common/manifest_handlers/file_handler_info.h » ('j') | extensions/common/manifest_handlers/file_handler_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_constants.cc

diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc

index 51b5570889cebfd86f4a3d0c54f99d5d0a710fdc..17cc94180b696ff4a6ff96c6992bf327824c83cc 100644

--- a/extensions/common/manifest_constants.cc

+++ b/extensions/common/manifest_constants.cc

@@ -50,6 +50,7 @@ const char kFileBrowserHandlers[] = "file_browser_handlers";

const char kFileHandlers[] = "file_handlers";

const char kFileHandlerExtensions[] = "extensions";

const char kFileHandlerTypes[] = "types";

+const char kFileHandlerVerb[] = "verb";

const char kGlobal[] = "global";

const char kHideBookmarkButton[] = "hide_bookmark_button";

const char kHomepageURL[] = "homepage_url";

@@ -406,6 +407,9 @@ const char kInvalidFileHandlerType[] =

"Invalid value for 'file_handlers[*].types'.";

const char kInvalidFileHandlerTypeElement[] =

"Invalid value for 'file_handlers[*].types[*]'.";

+const char kInvalidFileHandlerVerb[] =

+ "Invalid value for 'verb'. Supported values are OPEN_WITH, ADD_TO and "

fukino 2016/04/13 08:03:12 It will be tough to maintain the list [OPEN_WITH,A

cmihail 2016/04/18 01:28:10 Done.

+ "PACK_WITH.";

const char kInvalidGlob[] =

"Invalid value for 'content_scripts[*].*[*]'.";

const char kInvalidGlobList[] =