Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/common/extensions/api/file_manager_private.idl

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum for verbs in idl file. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/file_manager_private.idl
diff --git a/chrome/common/extensions/api/file_manager_private.idl b/chrome/common/extensions/api/file_manager_private.idl
index 1f9248643aabee8e8274ca0fe20cb77682eb7c3f..40c3ae377ace92611d4064e34e1417c89fbe13ad 100644
--- a/chrome/common/extensions/api/file_manager_private.idl
+++ b/chrome/common/extensions/api/file_manager_private.idl
@@ -184,6 +184,13 @@ enum Source {
system
};
+// File handler verbs.
Devlin 2016/05/18 18:49:41 This should have a better description.
cmihail 2016/05/18 22:53:36 Done.
+enum Verb {
+ open_with,
+ add_to,
+ pack_with
+};
+
// A file task represents an action that the file manager can perform over the
// currently selected files. See
// chrome/browser/chromeos/extensions/file_manager/file_tasks.h for details
@@ -195,6 +202,10 @@ dictionary FileTask {
// Task title (ex. App name).
DOMString title;
+ // Task verb (ex. Open With). Can be empty string in case of no verb
+ // (i.e. for FileBrowserHandler).
+ Verb verb;
Devlin 2016/05/18 18:49:40 why not just make it an optional field?
cmihail 2016/05/18 22:53:36 Done.
+
// Task icon url (from chrome://extension-icon/...)
DOMString iconUrl;

Powered by Google App Engine
This is Rietveld 408576698