Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Side by Side Diff: chrome/common/extensions/api/file_manager_private.idl

Issue 1872223002: Add verbs API to file handlers. Modify the Chrome OS UI so that it displayes the internationalized … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add an enum for verbs in idl file. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // fileManagerPrivate API. 5 // fileManagerPrivate API.
6 // This is a private API used by the file browser of ChromeOS. 6 // This is a private API used by the file browser of ChromeOS.
7 [platforms=("chromeos"), 7 [platforms=("chromeos"),
8 implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_pr ivate_api_functions.h"] 8 implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_pr ivate_api_functions.h"]
9 namespace fileManagerPrivate { 9 namespace fileManagerPrivate {
10 // Type of the mounted volume. 10 // Type of the mounted volume.
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 }; 177 };
178 178
179 // Source of the volume data. 179 // Source of the volume data.
180 enum Source { 180 enum Source {
181 file, 181 file,
182 device, 182 device,
183 network, 183 network,
184 system 184 system
185 }; 185 };
186 186
187 // File handler verbs.
Devlin 2016/05/18 18:49:41 This should have a better description.
cmihail 2016/05/18 22:53:36 Done.
188 enum Verb {
189 open_with,
190 add_to,
191 pack_with
192 };
193
187 // A file task represents an action that the file manager can perform over the 194 // A file task represents an action that the file manager can perform over the
188 // currently selected files. See 195 // currently selected files. See
189 // chrome/browser/chromeos/extensions/file_manager/file_tasks.h for details 196 // chrome/browser/chromeos/extensions/file_manager/file_tasks.h for details
190 // about how file tasks are handled. 197 // about how file tasks are handled.
191 dictionary FileTask { 198 dictionary FileTask {
192 // The unique identifier of the task. 199 // The unique identifier of the task.
193 DOMString taskId; 200 DOMString taskId;
194 201
195 // Task title (ex. App name). 202 // Task title (ex. App name).
196 DOMString title; 203 DOMString title;
197 204
205 // Task verb (ex. Open With). Can be empty string in case of no verb
206 // (i.e. for FileBrowserHandler).
207 Verb verb;
Devlin 2016/05/18 18:49:40 why not just make it an optional field?
cmihail 2016/05/18 22:53:36 Done.
208
198 // Task icon url (from chrome://extension-icon/...) 209 // Task icon url (from chrome://extension-icon/...)
199 DOMString iconUrl; 210 DOMString iconUrl;
200 211
201 // True if this task is a default task for the selected files. 212 // True if this task is a default task for the selected files.
202 boolean isDefault; 213 boolean isDefault;
203 214
204 // True if this task is from generic file handler. Generic file handler is a 215 // True if this task is from generic file handler. Generic file handler is a
205 // file handler which handles any type of files (e.g. extensions: ["*"], 216 // file handler which handles any type of files (e.g. extensions: ["*"],
206 // types: ["*/*"]). Partial wild card (e.g. types: ["image/*"]) is not 217 // types: ["*/*"]). Partial wild card (e.g. types: ["image/*"]) is not
207 // generic file handler. 218 // generic file handler.
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
969 980
970 static void onPreferencesChanged(); 981 static void onPreferencesChanged();
971 982
972 static void onDriveConnectionStatusChanged(); 983 static void onDriveConnectionStatusChanged();
973 984
974 static void onDeviceChanged(DeviceEvent event); 985 static void onDeviceChanged(DeviceEvent event);
975 986
976 static void onDriveSyncError(DriveSyncErrorEvent event); 987 static void onDriveSyncError(DriveSyncErrorEvent event);
977 }; 988 };
978 }; 989 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698