Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1872013002: Fix Android accessibility for editable text fields (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index 4a1b39dc001f2624f6402bb5e8d805d49e0b822c..e7cf912a46d5c9e9043e85cee4c3108d4b775630 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -405,10 +405,11 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(
base::android::ConvertUTF8ToJavaString(env, node->GetClassName()).obj());
if (!node->IsPassword() ||
David Tseng 2016/04/11 16:48:34 How do we currently work with input type password?
dmazzoni 2016/04/11 20:49:06 There's an Android setting that determines whether
David Tseng 2016/04/11 21:01:41 I thought it wasn't so much that it was echoed, bu
Java_BrowserAccessibilityManager_shouldExposePasswordText(env, obj)) {
- Java_BrowserAccessibilityManager_setAccessibilityNodeInfoContentDescription(
+ Java_BrowserAccessibilityManager_setAccessibilityNodeInfoText(
env, obj, info,
base::android::ConvertUTF16ToJavaString(env, node->GetText()).obj(),
- node->IsLink());
+ node->IsLink(),
+ node->IsEditableText());
}
base::string16 element_id;
if (node->GetHtmlAttribute("id", &element_id)) {

Powered by Google App Engine
This is Rietveld 408576698