Fix Android accessibility for editable text fields

content/browser/accessibility/browser_accessibility_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_manager_android.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 385 matching lines @@
       node->CanScrollLeft(),
       node->CanScrollRight(),
       node->IsClickable(),
       node->IsEditableText(),
       node->IsEnabled(),
       node->IsFocusable(),
       node->IsFocused());
   Java_BrowserAccessibilityManager_setAccessibilityNodeInfoClassName(
       env, obj, info,
       base::android::ConvertUTF8ToJavaString(env, node->GetClassName()).obj());
   if (!node->IsPassword() ||

[David Tseng, 2016/04/11 16:48:34]

How do we currently work with input type password?

[dmazzoni, 2016/04/11 20:49:06]

There's an Android setting that determines whether it's
echoed or not, that's what this checks. So if it is
echoed, we use this API to announce it whether it's a
password field or not. If it is not echoed we don't set
the text.

[David Tseng, 2016/04/11 21:01:41]

I thought it wasn't so much that it was echoed, but the characters were
*/dotted-ed out?

       Java_BrowserAccessibilityManager_shouldExposePasswordText(env, obj)) {
-    Java_BrowserAccessibilityManager_setAccessibilityNodeInfoContentDescription(
+    Java_BrowserAccessibilityManager_setAccessibilityNodeInfoText(
         env, obj, info,
         base::android::ConvertUTF16ToJavaString(env, node->GetText()).obj(),
-        node->IsLink());
+        node->IsLink(),
+        node->IsEditableText());
   }
   base::string16 element_id;
   if (node->GetHtmlAttribute("id", &element_id)) {
     Java_BrowserAccessibilityManager_setAccessibilityNodeInfoViewIdResourceName(
         env, obj, info,
         base::android::ConvertUTF16ToJavaString(env, element_id).obj());
   }
 
   gfx::Rect absolute_rect = node->GetLocalBoundsRect();
   gfx::Rect parent_relative_rect = absolute_rect;
@@ skipping 521 matching lines @@
 
   JNIEnv* env = AttachCurrentThread();
   return root_manager->java_ref().get(env);
 }
 
 bool RegisterBrowserAccessibilityManager(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content