Source/core/rendering/compositing/GraphicsLayerUpdater.h - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/GraphicsLayerUpdater.h

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fullscreen/full-screen-iframe-allowed-video.html ('K') | « LayoutTests/virtual/android/fullscreen/video-specified-size-expected.png ('k') | Source/core/rendering/compositing/GraphicsLayerUpdater.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/compositing/GraphicsLayerUpdater.h

diff --git a/Source/core/rendering/compositing/GraphicsLayerUpdater.h b/Source/core/rendering/compositing/GraphicsLayerUpdater.h

index 9b9658a2762919cade645aef2298c6e18d87f639..838558042f95417311da2ef09be2ae56c6d6fdb4 100644

--- a/Source/core/rendering/compositing/GraphicsLayerUpdater.h

+++ b/Source/core/rendering/compositing/GraphicsLayerUpdater.h

@@ -46,6 +46,7 @@ public:

private:

void update(RenderLayer&);

+ bool shouldAppendLayer(RenderLayer&);

esprehn 2014/03/05 04:36:03 This can just be a function in the file, or if you

qinmin 2014/03/05 18:45:25 Done.

RenderView& m_renderView;