Source/core/rendering/compositing/GraphicsLayerUpdater.h - Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/compositing/GraphicsLayerUpdater.h

Issue 187193002: Fix an issue that subtitle is not shown for native fullscreen video that is inside an iframe (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fullscreen/full-screen-iframe-allowed-video.html ('K') | « LayoutTests/virtual/android/fullscreen/video-specified-size-expected.png ('k') | Source/core/rendering/compositing/GraphicsLayerUpdater.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2014 Google Inc. All rights reserved.	3 * Copyright (C) 2014 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 28 matching lines...) Expand all Loading...
39 class GraphicsLayerUpdater {	39 class GraphicsLayerUpdater {

40 public:	40 public:

41 explicit GraphicsLayerUpdater(RenderView&);	41 explicit GraphicsLayerUpdater(RenderView&);

42 ~GraphicsLayerUpdater();	42 ~GraphicsLayerUpdater();

43	43

44 void updateRecursive(RenderLayer&);	44 void updateRecursive(RenderLayer&);

45 void rebuildTree(RenderLayer&, Vector<GraphicsLayer*>& childLayersOfEnclosin gLayer, int depth);	45 void rebuildTree(RenderLayer&, Vector<GraphicsLayer*>& childLayersOfEnclosin gLayer, int depth);

46	46

47 private:	47 private:

48 void update(RenderLayer&);	48 void update(RenderLayer&);

	49 bool shouldAppendLayer(RenderLayer&);
	esprehn 2014/03/05 04:36:03 This can just be a function in the file, or if you This can just be a function in the file, or if you want it here static. Also const RenderLayer& qinmin 2014/03/05 18:45:25 Done. Show quoted text On 2014/03/05 04:36:03, esprehn wrote: > This can just be a function in the file, or if you want it here static. Also > const RenderLayer& Done.
49	50

50 RenderView& m_renderView;	51 RenderView& m_renderView;

51	52

52 // Used for gathering UMA data about the effect on memory usage of promoting all layers	53 // Used for gathering UMA data about the effect on memory usage of promoting all layers

53 // that have a webkit-transition on opacity or transform and intersect the v iewport.	54 // that have a webkit-transition on opacity or transform and intersect the v iewport.

54 double m_pixelsWithoutPromotingAllTransitions;	55 double m_pixelsWithoutPromotingAllTransitions;

55 double m_pixelsAddedByPromotingAllTransitions;	56 double m_pixelsAddedByPromotingAllTransitions;

56 };	57 };

57	58

58 } // namespace WebCore	59 } // namespace WebCore

59	60

60 #endif // GraphicsLayerUpdater_h	61 #endif // GraphicsLayerUpdater_h

OLD	NEW