Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
index 75d64f0a3cd2494e6843e46692647c04a9c41691..a24a327b3c6d379288657c5aa5fcc60d75173a66 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc
@@ -4,7 +4,8 @@
#include "chrome/browser/extensions/api/developer_private/developer_private_mangle.h"
-#include "base/memory/scoped_ptr.h"
+#include <memory>
+
#include "base/values.h"
#include "chrome/common/extensions/api/developer_private.h"
#include "extensions/browser/extension_error.h"
@@ -80,14 +81,14 @@ api::developer_private::ItemInfo MangleExtensionInfo(
}
for (const api::developer_private::ManifestError& error :
info.manifest_errors) {
- scoped_ptr<base::DictionaryValue> value = error.ToValue();
+ std::unique_ptr<base::DictionaryValue> value = error.ToValue();
value->SetInteger("type", static_cast<int>(ExtensionError::MANIFEST_ERROR));
value->SetInteger("level", static_cast<int>(logging::LOG_WARNING));
result.manifest_errors.push_back(std::move(value));
}
for (const api::developer_private::RuntimeError& error :
info.runtime_errors) {
- scoped_ptr<base::DictionaryValue> value = error.ToValue();
+ std::unique_ptr<base::DictionaryValue> value = error.ToValue();
value->SetInteger("type", static_cast<int>(ExtensionError::RUNTIME_ERROR));
logging::LogSeverity severity = logging::LOG_INFO;
if (error.severity == api::developer_private::ERROR_LEVEL_WARN)

Powered by Google App Engine
This is Rietveld 408576698