chrome/browser/extensions/api/omnibox/omnibox_api.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api.h

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api.h b/chrome/browser/extensions/api/omnibox/omnibox_api.h

index 9c36a7c1b3168b98fabc771cacfa3b9b34982b39..d49ecc1f2809752154bc031920537ed0f69c5c9a 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api.h

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api.h

@@ -5,11 +5,11 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_OMNIBOX_OMNIBOX_API_H_

#define CHROME_BROWSER_EXTENSIONS_API_OMNIBOX_OMNIBOX_API_H_

+#include <memory>

#include <set>

#include <string>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/scoped_observer.h"

#include "base/strings/string16.h"

#include "chrome/browser/extensions/chrome_extension_function.h"

@@ -142,7 +142,7 @@ class OmniboxAPI : public BrowserContextKeyedAPI,

ExtensionIconManager omnibox_icon_manager_;

ExtensionIconManager omnibox_popup_icon_manager_;

- scoped_ptr<TemplateURLService::Subscription> template_url_sub_;

+ std::unique_ptr<TemplateURLService::Subscription> template_url_sub_;

DISALLOW_COPY_AND_ASSIGN(OmniboxAPI);

};