chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js - Issue 1871653002: Settings People Revamp: Update ManageProfileHandler to use Promises.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js

Issue 1871653002: Settings People Revamp: Update ManageProfileHandler to use Promises. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/manage_profile.js ('k') | chrome/browser/ui/webui/settings/settings_manage_profile_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js

diff --git a/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js b/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js

index 1607fd91cf1ef01235ae3a3547d59a789db932c8..48c03b7e78010cc1987d9aa76a26ee1840bb67ad 100644

--- a/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js

+++ b/chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js

@@ -12,8 +12,8 @@ cr.define('settings', function() {

ManageProfileBrowserProxy.prototype = {

/**

- * Gets the available profile icons to choose from. As a response, the C++

- * sends the 'available-icons-changed' WebUIListener event.

+ * Gets the available profile icons to choose from.

+ * @return {!Promise<!Array<string>>}

getAvailableIcons: function() {},

@@ -37,7 +37,7 @@ cr.define('settings', function() {

ManageProfileBrowserProxyImpl.prototype = {

/** @override */

getAvailableIcons: function() {

- chrome.send('getAvailableIcons');

+ return cr.sendWithPromise('getAvailableIcons');

/** @override */