chrome/browser/resources/settings/people_page/manage_profile.js - Issue 1871653002: Settings People Revamp: Update ManageProfileHandler to use Promises.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/manage_profile.js

Issue 1871653002: Settings People Revamp: Update ManageProfileHandler to use Promises. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/people_page/manage_profile.js

diff --git a/chrome/browser/resources/settings/people_page/manage_profile.js b/chrome/browser/resources/settings/people_page/manage_profile.js

index 243548da6eb903cdae19693e2ebb7bcd29fcd105..2851f688a4de9900de3797e8d5618987523382dc 100644

--- a/chrome/browser/resources/settings/people_page/manage_profile.js

+++ b/chrome/browser/resources/settings/people_page/manage_profile.js

@@ -45,11 +45,12 @@ Polymer({

/** @override */

attached: function() {

- this.addWebUIListener('available-icons-changed', function(iconUrls) {

+ var setIcons = function(iconUrls) {

this.availableIconUrls = iconUrls;

- }.bind(this));

+ }.bind(this);

- this.browserProxy_.getAvailableIcons();

+ this.addWebUIListener('available-icons-changed', setIcons);

+ this.browserProxy_.getAvailableIcons().then(setIcons);

/**

« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/manage_profile_browser_proxy.js » ('j') | no next file with comments »