Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1871623002: Added chrome child pdb to isolate for static library builds. (Closed)

Created:
4 years, 8 months ago by David Yen
Modified:
4 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added chrome child pdb to isolate for static library builds. BUG=561763 Committed: https://crrev.com/1f4aa76f63ec6c81e5e5836bfdda4b755d9b3abc Cr-Commit-Position: refs/heads/master@{#385818}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M chrome/chrome.isolate View 2 chunks +11 lines, -4 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
David Yen
Added a missing pdb, I also moved where the pdb lines in the isolate file ...
4 years, 8 months ago (2016-04-07 18:00:04 UTC) #2
M-A Ruel
https://codereview.chromium.org/1871623002/diff/1/chrome/chrome.isolate File chrome/chrome.isolate (right): https://codereview.chromium.org/1871623002/diff/1/chrome/chrome.isolate#newcode52 chrome/chrome.isolate:52: '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX).pdb', you can use chrome.exe.pdb, it's more readable. I'm ...
4 years, 8 months ago (2016-04-07 18:07:58 UTC) #3
David Yen
https://codereview.chromium.org/1871623002/diff/1/chrome/chrome.isolate File chrome/chrome.isolate (right): https://codereview.chromium.org/1871623002/diff/1/chrome/chrome.isolate#newcode52 chrome/chrome.isolate:52: '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX).pdb', On 2016/04/07 18:07:58, M-A Ruel wrote: > you ...
4 years, 8 months ago (2016-04-07 18:11:43 UTC) #4
M-A Ruel
ok, lgtm
4 years, 8 months ago (2016-04-07 18:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871623002/1
4 years, 8 months ago (2016-04-07 18:23:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 18:37:22 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 18:39:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f4aa76f63ec6c81e5e5836bfdda4b755d9b3abc
Cr-Commit-Position: refs/heads/master@{#385818}

Powered by Google App Engine
This is Rietveld 408576698