Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1862123005: Testing for issue 1859013002 (Closed)

Created:
4 years, 8 months ago by David Yen
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome_pdbs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Testing for issue 1859013002 Copy cdb.exe into telemetry_chrome_test's isolate. This binary needs to be available on the Swarming bots, but only Google employees and the bots have access to the hermetic Windows toolchain. Since the isolates are only built by these entities, only copy and bundle them in this situation. BUG=561763 patch from issue 1859013002 at patchset 80001 (http://crrev.com/1859013002#ps80001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -8 lines) Patch
A build/win/copy_cdb_to_output.py View 1 chunk +83 lines, -0 lines 0 comments Download
A + chrome/cdb.isolate View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +34 lines, -0 lines 0 comments Download
M tools/perf/chrome_telemetry_build/telemetry_chrome_test.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/core/stacktrace_unittest.py View 2 chunks +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1871623002 Patch 1

Messages

Total messages: 3 (2 generated)
David Yen
4 years, 8 months ago (2016-04-07 18:24:04 UTC) #3
Message was sent while issue was closed. 
Closing since the CLs passed.

Powered by Google App Engine
This is Rietveld 408576698