Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: content/common/gpu/gpu_channel.cc

Issue 1871613002: Compute GpuDriverBugWorkarounds only one time in the GPU process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/gpu/gpu_channel_manager.h » ('j') | gpu/command_buffer/service/feature_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel.cc
diff --git a/content/common/gpu/gpu_channel.cc b/content/common/gpu/gpu_channel.cc
index 20edeafa8467e1ad4f42da2350c052003e8be2a6..aa62b7e823bf7d81473382aba4ca0405f5db48b3 100644
--- a/content/common/gpu/gpu_channel.cc
+++ b/content/common/gpu/gpu_channel.cc
@@ -982,16 +982,9 @@ void GpuChannel::OnDestroyCommandBuffer(int32_t route_id) {
void GpuChannel::OnGetDriverBugWorkArounds(
std::vector<std::string>* gpu_driver_bug_workarounds) {
- // TODO(j.isorce): http://crbug.com/599964 Do the extraction of workarounds in
- // the GpuChannelManager constructor. Currently it is done in the FeatureInfo
- // constructor. There is no need to extract them from the command-line every
- // time a new FeatureInfo is created (i.e. per ContextGroup) since parsing
- // result is a constant.
- scoped_refptr<gpu::gles2::FeatureInfo> feature_info =
- new gpu::gles2::FeatureInfo;
gpu_driver_bug_workarounds->clear();
-#define GPU_OP(type, name) \
- if (feature_info->workarounds().name) \
+#define GPU_OP(type, name) \
+ if (gpu_channel_manager_->gpu_driver_bug_workarounds().name) \
gpu_driver_bug_workarounds->push_back(#name);
GPU_DRIVER_BUG_WORKAROUNDS(GPU_OP)
#undef GPU_OP
« no previous file with comments | « no previous file | content/common/gpu/gpu_channel_manager.h » ('j') | gpu/command_buffer/service/feature_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698