Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1871453002: Fix telemetry viewport calculations for gestures when zoomed in.

Created:
4 years, 8 months ago by bokan
Modified:
4 years, 8 months ago
Reviewers:
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fix telemetry viewport calculations for gestures when zoomed in. The gesture code tries to calculate the bounding rect for a given element relative to the viewport in order to send gestures to that element. However, when the page is pinch-zoomed in, the gesture code expects the bounding rect to be relative to the visual viewport, that is, what the user sees. The current code was calculating this incorrectly in the presence of pinch-zoom. In fact, it's impossible to calculate correctly without adding additional information about the visual viewport to the gpuBenchmarking extensions. This CL depends on landing http://crrev.com/1866793003 and uses the additional information to accurately calculate the element's rect relative to the visual viewport. BUG=chromium:564008

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M telemetry/telemetry/internal/actions/gesture_common.js View 1 chunk +43 lines, -22 lines 0 comments Download
M telemetry/telemetry/internal/actions/pinch.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (3 generated)
bokan
Description was changed from ========== Fix viewport calculations in pinch gestures. BUG=catapult:# ========== to ========== ...
4 years, 8 months ago (2016-04-07 03:49:27 UTC) #1
bokan
Description was changed from ========== Fix viewport calculations in pinch gestures. BUG=chromium:564008 ========== to ========== ...
4 years, 8 months ago (2016-04-07 16:20:52 UTC) #2
bokan
4 years, 8 months ago (2016-04-07 21:37:52 UTC) #3
Description was changed from

==========
Fix viewport calculations for gestures when zoomed in.

The gesture code tries to calculate the bounding rect for a given
element relative to the viewport in order to send gestures to that
element. However, when the page is pinch-zoomed in, the gesture
code expects the bounding rect to be relative to the visual viewport,
that is, what the user sees. The current code was calculating this
incorrectly in the presence of pinch-zoom. In fact, it's impossible
to calculate correctly without adding additional information about
the visual viewport to the gpuBenchmarking extensions.

This CL depends on landing http://crrev.com/1866793003 and uses the
additional information to accurately calculate the element's rect
relative to the visual viewport.

BUG=chromium:564008
==========

to

==========
Fix telemetry viewport calculations for gestures when zoomed in.

The gesture code tries to calculate the bounding rect for a given
element relative to the viewport in order to send gestures to that
element. However, when the page is pinch-zoomed in, the gesture
code expects the bounding rect to be relative to the visual viewport,
that is, what the user sees. The current code was calculating this
incorrectly in the presence of pinch-zoom. In fact, it's impossible
to calculate correctly without adding additional information about
the visual viewport to the gpuBenchmarking extensions.

This CL depends on landing http://crrev.com/1866793003 and uses the
additional information to accurately calculate the element's rect
relative to the visual viewport.

BUG=chromium:564008
==========

Powered by Google App Engine
This is Rietveld 408576698