telemetry/telemetry/internal/actions/pinch.py - Issue 1871453002: Fix telemetry viewport calculations for gestures when zoomed in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/actions/pinch.py

Issue 1871453002: Fix telemetry viewport calculations for gestures when zoomed in. Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: telemetry/telemetry/internal/actions/pinch.py

diff --git a/telemetry/telemetry/internal/actions/pinch.py b/telemetry/telemetry/internal/actions/pinch.py

index c1d76b6647efb6f36f42741e8c05ecc8aef1ee15..2d799379ffaeb3857f55aa01c6761be54d72b874 100644

--- a/telemetry/telemetry/internal/actions/pinch.py

+++ b/telemetry/telemetry/internal/actions/pinch.py

@@ -46,7 +46,7 @@ class PinchAction(page_action.PageAction):

@staticmethod

def _GetDefaultScaleFactorForPage(tab):

current_scale_factor = tab.EvaluateJavaScript(

- 'window.outerWidth / window.innerWidth')

+ 'window.gpuBenchmarking.pageScaleFactor()')

return 3.0 / current_scale_factor

def RunAction(self, tab):

« no previous file with comments | « telemetry/telemetry/internal/actions/gesture_common.js ('k') | no next file » | no next file with comments »