Alternative fix for FindToolbar crash when reparenting.

Alternative fix for FindToolbar crash when reparenting.

As part of the fix for crbug.com/592315, TabModelObserver.tabRemoved()
is currently called *before* removing the tab from the model. This is
inconvenient since most (future) listeners of tabRemoved() need to know
the state *after* the tab has been removed.

New approach: FindToolbar now holds the WindowAndroid directly, instead
of using mTabModelSelector.getCurrentTab().getWindowAndroid() (which
fails after the last tab has been removed).

This also fixes a memory leak where FindToolbar held a reference
indefinitely to the last tab on which find-in-page was used.

BUG=595889
Committed: https://crrev.com/00daa0b973e09d63d8d1d9d637eccf1228e3c542
Cr-Commit-Position: refs/heads/master@{#385856}

[newt (away), 2016-04-07 01:45:01]

newt@chromium.org changed reviewers:
+ yusufo@chromium.org

[newt (away), 2016-04-07 01:45:01]

PTAL

[Yusuf, 2016-04-07 17:29:19]

lgtm

[newt (away), 2016-04-07 17:30:29]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2016-04-07 17:30:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871433002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871433002/1

[commit-bot: I haz the power, 2016-04-07 17:42:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 17:42:43]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[newt (away), 2016-04-07 20:28:47]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-04-07 20:28:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1871433002/#ps20001
(title: "fix compile and rebase")

[commit-bot: I haz the power, 2016-04-07 20:29:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871433002/20001

[commit-bot: I haz the power, 2016-04-07 21:17:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 21:29:34]

Description was changed from

==========
Alternative fix for FindToolbar crash when reparenting.

As part of the fix for crbug.com/592315, TabModelObserver.tabRemoved()
is currently called *before* removing the tab from the model. This is
inconvenient since most (future) listeners of tabRemoved() need to know
the state *after* the tab has been removed.

New approach: FindToolbar now holds the WindowAndroid directly, instead
of using mTabModelSelector.getCurrentTab().getWindowAndroid() (which
fails after the last tab has been removed).

This also fixes a memory leak where FindToolbar held a reference
indefinitely to the last tab on which find-in-page was used.

BUG=595889
==========

to

==========
Alternative fix for FindToolbar crash when reparenting.

As part of the fix for crbug.com/592315, TabModelObserver.tabRemoved()
is currently called *before* removing the tab from the model. This is
inconvenient since most (future) listeners of tabRemoved() need to know
the state *after* the tab has been removed.

New approach: FindToolbar now holds the WindowAndroid directly, instead
of using mTabModelSelector.getCurrentTab().getWindowAndroid() (which
fails after the last tab has been removed).

This also fixes a memory leak where FindToolbar held a reference
indefinitely to the last tab on which find-in-page was used.

BUG=595889

Committed: https://crrev.com/00daa0b973e09d63d8d1d9d637eccf1228e3c542
Cr-Commit-Position: refs/heads/master@{#385856}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:35]

Patchset 2 (id:??) landed as
https://crrev.com/00daa0b973e09d63d8d1d9d637eccf1228e3c542
Cr-Commit-Position: refs/heads/master@{#385856}