components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/common/page_load_timing.cc ('k') | third_party/WebKit/Source/core/timing/PerformanceTiming.h » ('j') | third_party/WebKit/Source/core/timing/PerformanceTiming.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index 237c99cc6b35c8e15dcea21be4c4610dc011a9cb..84e009c34de72f7d35b3f26219be9909a63bf5d9 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -109,6 +109,7 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {

PageLoadTiming timing;

double start = perf.navigationStart();

timing.navigation_start = base::Time::FromDoubleT(start);

+ timing.worker_start = base::Time::FromDoubleT(perf.workerStart());

timing.response_start = ClampDelta(perf.responseStart(), start);

timing.dom_loading = ClampDelta(perf.domLoading(), start);

timing.dom_content_loaded_event_start =