components/page_load_metrics/common/page_load_timing.cc - Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/common/page_load_timing.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('j') | third_party/WebKit/Source/core/timing/PerformanceTiming.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/page_load_timing.cc

diff --git a/components/page_load_metrics/common/page_load_timing.cc b/components/page_load_metrics/common/page_load_timing.cc

index 7c368204551f40d17cc50dbd3d55f22e85aab254..770f9b722ad4c647602900eb6fa4c0fbb67b9876 100644

--- a/components/page_load_metrics/common/page_load_timing.cc

+++ b/components/page_load_metrics/common/page_load_timing.cc

@@ -14,6 +14,7 @@ PageLoadTiming::~PageLoadTiming() {}

bool PageLoadTiming::operator==(const PageLoadTiming& other) const {

return navigation_start == other.navigation_start &&

+ worker_start == other.worker_start &&

response_start == other.response_start &&

dom_loading == other.dom_loading &&

dom_content_loaded_event_start ==

@@ -31,8 +32,9 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {

}

bool PageLoadTiming::IsEmpty() const {

- return navigation_start.is_null() && response_start.is_zero() &&

- dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() &&

+ return navigation_start.is_null() && worker_start.is_null() &&

+ response_start.is_zero() && dom_loading.is_zero() &&

+ dom_content_loaded_event_start.is_zero() &&

load_event_start.is_zero() && first_layout.is_zero() &&

first_paint.is_zero() && first_text_paint.is_zero() &&

first_image_paint.is_zero() && parse_start.is_zero() &&