Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1871393002: Add NavigationToFirstContentfulPaint UMA for ServiceWorker controlled pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment and check ShouldSendMetrics() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc
diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
index 260d3b6285d48c68a63ce22b127e9b70890555ad..812c281152bc4132907a2328da8162658194096c 100644
--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
@@ -41,6 +41,8 @@ void MetricsRenderFrameObserver::DidChangePerformanceTiming() {
void MetricsRenderFrameObserver::DidObserveLoadingBehavior(
blink::WebLoadingBehaviorFlag behavior) {
+ if (!ShouldSendMetrics())
Charlie Harrison 2016/04/14 13:29:56 Actually, I think I retract my comment. This won't
horo 2016/04/14 14:01:30 Changed to check page_timing_metrics_sender_
+ return;
DCHECK(page_timing_metrics_sender_);
page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);
}
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698