Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h" | 5 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h" |
| 6 | 6 |
| 7 #include <string> | 7 #include <string> |
| 8 | 8 |
| 9 #include "base/time/time.h" | 9 #include "base/time/time.h" |
| 10 #include "base/timer/timer.h" | 10 #include "base/timer/timer.h" |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 34 : content::RenderFrameObserver(render_frame) {} | 34 : content::RenderFrameObserver(render_frame) {} |
| 35 | 35 |
| 36 MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {} | 36 MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {} |
| 37 | 37 |
| 38 void MetricsRenderFrameObserver::DidChangePerformanceTiming() { | 38 void MetricsRenderFrameObserver::DidChangePerformanceTiming() { |
| 39 SendMetrics(); | 39 SendMetrics(); |
| 40 } | 40 } |
| 41 | 41 |
| 42 void MetricsRenderFrameObserver::DidObserveLoadingBehavior( | 42 void MetricsRenderFrameObserver::DidObserveLoadingBehavior( |
| 43 blink::WebLoadingBehaviorFlag behavior) { | 43 blink::WebLoadingBehaviorFlag behavior) { |
| 44 if (!ShouldSendMetrics()) | |
|
Charlie Harrison
2016/04/14 13:29:56
Actually, I think I retract my comment. This won't
horo
2016/04/14 14:01:30
Changed to check page_timing_metrics_sender_
| |
| 45 return; | |
| 44 DCHECK(page_timing_metrics_sender_); | 46 DCHECK(page_timing_metrics_sender_); |
| 45 page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior); | 47 page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior); |
| 46 } | 48 } |
| 47 | 49 |
| 48 void MetricsRenderFrameObserver::DidCommitProvisionalLoad( | 50 void MetricsRenderFrameObserver::DidCommitProvisionalLoad( |
| 49 bool is_new_navigation, | 51 bool is_new_navigation, |
| 50 bool is_same_page_navigation) { | 52 bool is_same_page_navigation) { |
| 51 // Same-page navigations (e.g. an in-document navigation from a fragment | 53 // Same-page navigations (e.g. an in-document navigation from a fragment |
| 52 // link) aren't full page loads, since they don't go to network to load the | 54 // link) aren't full page loads, since they don't go to network to load the |
| 53 // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same | 55 // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 140 return make_scoped_ptr(new base::OneShotTimer); | 142 return make_scoped_ptr(new base::OneShotTimer); |
| 141 } | 143 } |
| 142 | 144 |
| 143 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { | 145 bool MetricsRenderFrameObserver::HasNoRenderFrame() const { |
| 144 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); | 146 bool no_frame = !render_frame() || !render_frame()->GetWebFrame(); |
| 145 DCHECK(!no_frame); | 147 DCHECK(!no_frame); |
| 146 return no_frame; | 148 return no_frame; |
| 147 } | 149 } |
| 148 | 150 |
| 149 } // namespace page_load_metrics | 151 } // namespace page_load_metrics |
| OLD | NEW |