chrome/android/java/res/values/colors.xml - Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/colors.xml

Issue 1871343006: [NTP Snippets] 📷 Add placeholders and start caching thumbnails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the async task out as it needs to be stopped from the view, not the snippet Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('K') | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/ThumbnailFetchingTask.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/values/colors.xml

diff --git a/chrome/android/java/res/values/colors.xml b/chrome/android/java/res/values/colors.xml

index 68db0f484288e792175c0f633de319826cd0f906..2276945a5fecb6fbd7f0115876e618d6a63e6e67 100644

--- a/chrome/android/java/res/values/colors.xml

+++ b/chrome/android/java/res/values/colors.xml

@@ -96,6 +96,7 @@

<color name="ntp_list_header_subtext_active">#7cadff</color>

+ <color name="snippets_thumnail_placeholder_bg">#f2f2f2</color>