Make PromiseResolver's members read-only

Make PromiseResolver's members read-only

R=dpapad@chromium.org
BUG=601916
Committed: https://crrev.com/e957950d791bd6eafddc9caed457119bcc94c53d
Cr-Commit-Position: refs/heads/master@{#386287}

[Dan Beam, 2016-04-08 22:16:57]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-04-08 22:19:52]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-04-08 22:23:38]

(and yes, i will need to do that weird dance where i add transitive dependencies
for third_party/closure_compiler/run_tests and the old v1 close GYP system :/)

[dpapad, 2016-04-08 22:32:49]

https://codereview.chromium.org/1871043004/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/webui_resource_browsertest.cc (right):

https://codereview.chromium.org/1871043004/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/webui_resource_browsertest.cc:246:
LoadFile(base::FilePath(FILE_PATH_LITERAL("promise_resolver_test.html")));
Thanks for adding tests! Just one comment/question:

I was hoping we were moving away from putting JS test code in HTML files. Would
it make sense if you convert this test to look more like our more recent mocha
based tests, as I did with
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...

[Dan Beam, 2016-04-08 23:11:21]

https://codereview.chromium.org/1871043004/diff/40001/chrome/test/data/webui/...
File chrome/test/data/webui/webui_resource_browsertest.cc (right):

https://codereview.chromium.org/1871043004/diff/40001/chrome/test/data/webui/...
chrome/test/data/webui/webui_resource_browsertest.cc:246:
LoadFile(base::FilePath(FILE_PATH_LITERAL("promise_resolver_test.html")));
On 2016/04/08 22:32:49, dpapad wrote:
> Thanks for adding tests! Just one comment/question:
> 
> I was hoping we were moving away from putting JS test code in HTML files.
Would
> it make sense if you convert this test to look more like our more recent mocha
> based tests, as I did with
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...

as per offline convo, i'll add a TODO to deprecate these tests and move them to
mocha (after this one)

[dpapad, 2016-04-08 23:12:08]

LGTM.

[Dan Beam, 2016-04-09 06:35:09]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-04-09 06:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1871043004/#ps60001
(title: "base off of https://codereview.chromium.org/1869883003/")

[commit-bot: I haz the power, 2016-04-09 06:35:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871043004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871043004/60001

[commit-bot: I haz the power, 2016-04-09 06:40:33]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-04-09 06:41:51]

Description was changed from

==========
Make PromiseResolver's members read-only

R=dpapad@chromium.org
BUG=601916
==========

to

==========
Make PromiseResolver's members read-only

R=dpapad@chromium.org
BUG=601916

Committed: https://crrev.com/e957950d791bd6eafddc9caed457119bcc94c53d
Cr-Commit-Position: refs/heads/master@{#386287}
==========

[commit-bot: I haz the power, 2016-04-09 06:41:52]

Patchset 2 (id:??) landed as
https://crrev.com/e957950d791bd6eafddc9caed457119bcc94c53d
Cr-Commit-Position: refs/heads/master@{#386287}