Make PromiseResolver's members read-only

chrome/test/data/webui/webui_resource_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/path_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/grit/options_test_resources.h"
@@ skipping 221 matching lines @@
   AddLibrary(IDR_WEBUI_JS_CR);
   AddLibrary(IDR_WEBUI_JS_CR_UI);
   AddLibrary(IDR_WEBUI_JS_CR_UI_SPLITTER);
   LoadFile(base::FilePath(FILE_PATH_LITERAL("splitter_test.html")));
 }
 
 IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, UtilTest) {
   AddLibrary(IDR_WEBUI_JS_UTIL);
   LoadFile(base::FilePath(FILE_PATH_LITERAL("util_test.html")));
 }
+
+IN_PROC_BROWSER_TEST_F(WebUIResourceBrowserTest, PromiseResolverTest) {
+  AddLibrary(IDR_WEBUI_JS_ASSERT);
+  AddLibrary(IDR_WEBUI_JS_PROMISE_RESOLVER);
+  LoadFile(base::FilePath(FILE_PATH_LITERAL("promise_resolver_test.html")));

[dpapad, 2016/04/08 22:32:49]

Thanks for adding tests! Just one comment/question:

I was hoping we were moving away from putting JS test code in HTML files. Would
it make sense if you convert this test to look more like our more recent mocha
based tests, as I did with
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...

[Dan Beam, 2016/04/08 23:11:21]

as per offline convo, i'll add a TODO to deprecate these tests and move them to
mocha (after this one)

+}