Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187103003: [webcrypto] Change HMAC key generation length from bytes to bits. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Change HMAC key generation length from bytes to bits. Matches the upstream change in the spec: https://dvcs.w3.org/hg/webcrypto-api/rev/da045968abe0 Corresponding blink-side change: https://codereview.chromium.org/184453005/ BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256025

Patch Set 1 : #

Total comments: 4

Patch Set 2 : do it #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M content/child/webcrypto/shared_crypto.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
eroman
6 years, 9 months ago (2014-03-06 20:29:42 UTC) #1
Ryan Sleevi
lgtm https://codereview.chromium.org/187103003/diff/20001/content/renderer/webcrypto/shared_crypto.cc File content/renderer/webcrypto/shared_crypto.cc (right): https://codereview.chromium.org/187103003/diff/20001/content/renderer/webcrypto/shared_crypto.cc#newcode318 content/renderer/webcrypto/shared_crypto.cc:318: #ifdef WEBCRYPTO_HMAC_BITS if defined(...) https://codereview.chromium.org/187103003/diff/20001/content/renderer/webcrypto/shared_crypto_unittest.cc File content/renderer/webcrypto/shared_crypto_unittest.cc (right): ...
6 years, 9 months ago (2014-03-06 21:51:37 UTC) #2
eroman
https://codereview.chromium.org/187103003/diff/20001/content/renderer/webcrypto/shared_crypto.cc File content/renderer/webcrypto/shared_crypto.cc (right): https://codereview.chromium.org/187103003/diff/20001/content/renderer/webcrypto/shared_crypto.cc#newcode318 content/renderer/webcrypto/shared_crypto.cc:318: #ifdef WEBCRYPTO_HMAC_BITS On 2014/03/06 21:51:37, Ryan Sleevi wrote: > ...
6 years, 9 months ago (2014-03-06 21:54:18 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-06 21:54:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/40001
6 years, 9 months ago (2014-03-06 22:33:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 00:23:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 00:23:26 UTC) #7
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-07 00:50:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/40001
6 years, 9 months ago (2014-03-07 00:59:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 10:13:05 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277144
6 years, 9 months ago (2014-03-07 10:13:06 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-07 18:38:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/60001
6 years, 9 months ago (2014-03-07 18:41:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/60001
6 years, 9 months ago (2014-03-07 20:23:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/60001
6 years, 9 months ago (2014-03-08 10:50:12 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 13:18:33 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278197
6 years, 9 months ago (2014-03-08 13:18:34 UTC) #17
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-10 18:29:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/187103003/60001
6 years, 9 months ago (2014-03-10 18:29:39 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 20:42:22 UTC) #20
Message was sent while issue was closed. 
Change committed as 256025

Powered by Google App Engine
This is Rietveld 408576698