Issue 184453005: [webcrypto] Change HMAC key generation length from bytes to bits.

Issue 184453005: [webcrypto] Change HMAC key generation length from bytes to bits. (Closed)

Created:
6 years, 9 months ago by eroman

Modified:
6 years, 9 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

[webcrypto] Change HMAC key generation length from bytes to bits. Matches the upstream change in the spec: https://dvcs.w3.org/hg/webcrypto-api/rev/da045968abe0 Corresponding chromium-side change: https://codereview.chromium.org/187103003/ BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168869

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	LayoutTests/crypto/generateKey.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/generateKey-expected.txt	View	1	3 chunks	+2 lines, -1 line	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebCrypto.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebCryptoAlgorithmParams.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 8 (0 generated)

eroman

Apologies, I forgot to re-base the tests. Fixed in patchset #2 (Also the chromium side ...

6 years, 9 months ago (2014-03-06 22:06:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/184453005/20001

6 years, 9 months ago (2014-03-10 20:58:46 UTC) #7

Message was sent while issue was closed.

Change committed as 168869