Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1870993002: Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (Closed)

Created:
4 years, 8 months ago by Michael Hablich
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (patchset #2 id:20001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/1838283003/ Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > R=epertoso@chromium.org > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} TBR=epertoso@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d1ec440f5d4df32f4deee1712633f1d565df2ff1 Cr-Commit-Position: refs/heads/master@{#35351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -612 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/builtins.h View 2 chunks +1 line, -10 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -193 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 5 chunks +1 line, -24 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 7 chunks +2 lines, -351 lines 0 comments Download
M src/js/messages.js View 4 chunks +3 lines, -2 lines 0 comments Download
M src/js/string.js View 4 chunks +34 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan.
4 years, 8 months ago (2016-04-08 11:24:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870993002/1
4 years, 8 months ago (2016-04-08 11:24:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 11:24:34 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 11:26:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1ec440f5d4df32f4deee1712633f1d565df2ff1
Cr-Commit-Position: refs/heads/master@{#35351}

Powered by Google App Engine
This is Rietveld 408576698