Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1870963002: Clean up CompositorPendingAnimations inclusion. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, tzik, eae+blinkwatch, fs, eric.carlson_apple.com, rwlbuis, blink-reviews-html_chromium.org, hongchan, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, Eric Willigers, nessy, rjwright, sof, timvolodine, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, nhiroki, darktears, vcarbune.chromium, philipj_slow, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, gasubic, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up CompositorPendingAnimations inclusion. No need for Document.h to include this header; remove + follow up on various IWYU violations that surfaces as a result. Also tidy up IntersectionObserver inclusion + remove its non-Oilpan code. R=haraken BUG= Committed: https://crrev.com/c106b283471522ed4d1fb93fd65816648d3d68fc Cr-Commit-Position: refs/heads/master@{#386042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -84 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildListMutationScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 5 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 3 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.h View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserverController.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeFilterCondition.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TouchList.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. Following up on a suggestion made a couple of weeks ago ...
4 years, 8 months ago (2016-04-08 09:26:40 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-08 09:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870963002/1
4 years, 8 months ago (2016-04-08 09:34:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 10:44:47 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 10:46:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c106b283471522ed4d1fb93fd65816648d3d68fc
Cr-Commit-Position: refs/heads/master@{#386042}

Powered by Google App Engine
This is Rietveld 408576698