third_party/WebKit/Source/core/dom/IntersectionObservation.cpp - Issue 1870963002: Clean up CompositorPendingAnimations inclusion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 1870963002: Clean up CompositorPendingAnimations inclusion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

index a6c36d712a0bff05614d86ea4e8861d9fae9ea4f..e5761255ebd4a0fbf6be81dce35e92afd8b39022 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

@@ -17,17 +17,12 @@ namespace blink {

IntersectionObservation::IntersectionObservation(IntersectionObserver& observer, Element& target, bool shouldReportRootBounds)

: m_observer(observer)

- , m_target(target.ensureIntersectionObserverData().createWeakPtr(&target))

+ , m_target(&target)

, m_shouldReportRootBounds(shouldReportRootBounds)

, m_lastThresholdIndex(0)

{

}

-Element* IntersectionObservation::target() const

- return toElement(m_target.get());

void IntersectionObservation::applyRootMargin(LayoutRect& rect) const

{

if (m_shouldReportRootBounds)