Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1870953002: diagnose_goma show summary as step text. (Closed)

Created:
4 years, 8 months ago by Yoshisato Yanagisawa
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

diagnose_goma show summary as step text. BUG=597496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
Yoshisato Yanagisawa
Hi, Let me show summary of diagnose_goma in diagnose_goma's step test. From version 103, diagnose_goma.py ...
4 years, 8 months ago (2016-04-08 07:56:02 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 8 months ago (2016-04-08 13:17:13 UTC) #4
Yoshisato Yanagisawa
ukai-san, can I ask you opinions on what you think of messages shown in the ...
4 years, 8 months ago (2016-04-11 01:13:46 UTC) #5
Yoshisato Yanagisawa
ping?
4 years, 8 months ago (2016-04-13 07:07:33 UTC) #6
Yoshisato Yanagisawa
4 years, 8 months ago (2016-04-13 07:08:15 UTC) #8
shinyak
lgtm
4 years, 8 months ago (2016-04-13 07:11:54 UTC) #9
Yoshisato Yanagisawa
mmm, let me submit the change first and listen opinions how you like this.
4 years, 8 months ago (2016-04-18 08:04:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870953002/1
4 years, 8 months ago (2016-04-18 08:05:13 UTC) #12
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 8 months ago (2016-04-18 08:05:16 UTC) #14
ukai
lgtm
4 years, 8 months ago (2016-04-26 01:00:10 UTC) #15
tikuta
4 years, 7 months ago (2016-05-11 02:34:02 UTC) #16
lgtm

Powered by Google App Engine
This is Rietveld 408576698