Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1870953002: diagnose_goma show summary as step text. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index 58a0fe05541d442aced7a19dbf692e56be6f31d0..57c91540e5bdbee5d21a9eca4ae17361015cfec0 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -1843,7 +1843,18 @@ class DiagnoseGomaTest(Test):
def run(self, api, suffix, test_filter=None):
diagnose_goma_log_py = api.path['build'].join('goma',
'diagnose_goma_log.py')
- api.python('diagnose_goma', diagnose_goma_log_py, [])
+ api.python('diagnose_goma', diagnose_goma_log_py,
+ ['--output-json', api.json.output()])
+ step_result = api.step.active_result
+ out_json = step_result.json
+ text_output = [
+ 'version %(goma_version)s, commit %(goma_revision)s' % output_json,
+ 'Fatal %(fatal)d, Error %(error)d, Warning %(warning)d' %
+ output_json['stats']
+ ]
+ text_output.extend(out_json['messages'])
+ step_result.presentation.step_text += api.test_utils.format_step_text(
+ text_output)
class IncrementalCoverageTest(Test):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698