Remove screen dependency from font_render_params_linux

Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761
Committed: https://crrev.com/c3e0ab3a37401a9dce852a1e770b81d33087651c
Cr-Commit-Position: refs/heads/master@{#386243}

[oshima, 2016-04-08 19:41:18]

Patchset #1 (id:1) has been deleted

[oshima, 2016-04-08 19:44:20]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-04-08 19:44:52]

Description was changed from

==========
Remove screen dependency from font_render_params_linux

BUG=597761
==========

to

==========
Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761
==========

[oshima, 2016-04-08 19:44:52]

oshima@chromium.org changed reviewers:
+ erg@chromium.org, msw@chromium.org

[oshima, 2016-04-08 19:57:05]

Patchset #1 (id:40001) has been deleted

[oshima, 2016-04-08 19:57:57]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 19:58:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870873003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870873003/60001

[oshima, 2016-04-08 19:58:40]

oshima@chromium.org changed reviewers:
+ sky@chromium.org
- msw@chromium.org

[oshima, 2016-04-08 19:59:25]

erg@ -> please review all
sky@ -> ui/gfx owner

[Daniel Erat, 2016-04-08 20:06:38]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-04-08 20:06:39]

lgtm

https://codereview.chromium.org/1870873003/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_x11.h (right):

https://codereview.chromium.org/1870873003/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_x11.h:74: void
SetDisplaysInternal(const std::vector<gfx::Display>& displays);
nit: add a comment describing what this does, e.g. "Updates |displays_| and sets
FontRenderParams's scale factor."

[Elliot Glaysher, 2016-04-08 20:10:23]

lgtm

[oshima, 2016-04-08 20:14:31]

Patchset #2 (id:80001) has been deleted

[oshima, 2016-04-08 20:15:40]

Patchset #2 (id:100001) has been deleted

[oshima, 2016-04-08 20:16:09]

https://codereview.chromium.org/1870873003/diff/60001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_screen_x11.h (right):

https://codereview.chromium.org/1870873003/diff/60001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_screen_x11.h:74: void
SetDisplaysInternal(const std::vector<gfx::Display>& displays);
On 2016/04/08 20:06:38, Daniel Erat wrote:
> nit: add a comment describing what this does, e.g. "Updates |displays_| and
sets
> FontRenderParams's scale factor."

Done.

[oshima, 2016-04-08 20:16:14]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 20:16:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870873003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870873003/120001

[msw, 2016-04-08 20:42:57]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-04-08 20:42:58]

just a driveby nit

https://codereview.chromium.org/1870873003/diff/120001/ui/gfx/font_render_par...
File ui/gfx/font_render_params.h (right):

https://codereview.chromium.org/1870873003/diff/120001/ui/gfx/font_render_par...
ui/gfx/font_render_params.h:111: #if defined(OS_CHROMEOS) || defined(OS_LINUX)
nit: Isn't OS_LINUX true on OS_CHROMEOS? If so, you can remove the OS_CHROMEOS
check and merge this with the OS_LINUX block above.

[commit-bot: I haz the power, 2016-04-08 21:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 21:23:15]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-04-08 21:28:17]

https://codereview.chromium.org/1870873003/diff/120001/ui/gfx/font_render_par...
File ui/gfx/font_render_params.h (right):

https://codereview.chromium.org/1870873003/diff/120001/ui/gfx/font_render_par...
ui/gfx/font_render_params.h:111: #if defined(OS_CHROMEOS) || defined(OS_LINUX)
On 2016/04/08 20:42:58, msw wrote:
> nit: Isn't OS_LINUX true on OS_CHROMEOS? If so, you can remove the OS_CHROMEOS
> check and merge this with the OS_LINUX block above.

That's technically true, although it still can be informative.

I don't have strong opinion and will follow the owner's recommendation as there
are other places that have this.

[sky, 2016-04-08 23:11:33]

LGTM

[oshima, 2016-04-08 23:21:41]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-04-08 23:21:41]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1870873003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-04-08 23:21:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870873003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870873003/120001

[commit-bot: I haz the power, 2016-04-08 23:28:55]

Description was changed from

==========
Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761
==========

to

==========
Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761
==========

[commit-bot: I haz the power, 2016-04-08 23:28:57]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-04-08 23:30:59]

Description was changed from

==========
Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761
==========

to

==========
Remove screen dependency from font_render_params_linux

This also allows linux to update the font params upon display change.

BUG=597761

Committed: https://crrev.com/c3e0ab3a37401a9dce852a1e770b81d33087651c
Cr-Commit-Position: refs/heads/master@{#386243}
==========

[commit-bot: I haz the power, 2016-04-08 23:31:00]

Patchset 2 (id:??) landed as
https://crrev.com/c3e0ab3a37401a9dce852a1e770b81d33087651c
Cr-Commit-Position: refs/heads/master@{#386243}