Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: ui/gfx/font_render_params_linux.cc

Issue 1870873003: Remove screen dependency from font_render_params_linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/font_render_params_linux.cc
diff --git a/ui/gfx/font_render_params_linux.cc b/ui/gfx/font_render_params_linux.cc
index 526c19d0188c64eb0f426e260eae620a8758840f..b2e8d5eb7742da1c402c0f3c69496ef2f8b989bc 100644
--- a/ui/gfx/font_render_params_linux.cc
+++ b/ui/gfx/font_render_params_linux.cc
@@ -19,21 +19,17 @@
#include "base/strings/stringprintf.h"
#include "base/synchronization/lock.h"
#include "build/build_config.h"
-#include "ui/gfx/display.h"
#include "ui/gfx/font.h"
#include "ui/gfx/linux_font_delegate.h"
-#include "ui/gfx/screen.h"
#include "ui/gfx/switches.h"
namespace gfx {
namespace {
-#if defined(OS_CHROMEOS)
-// A device scale factor for an internal display (if any)
-// that is used to determine if subpixel positioning should be used.
-float device_scale_factor_for_internal_display = 1.0f;
-#endif
+// A device scale factor used to determine if subpixel positioning
+// should be used.
+float device_scale_factor_ = 1.0f;
// Number of recent GetFontRenderParams() results to cache.
const size_t kCacheSize = 256;
@@ -204,19 +200,9 @@ uint32_t HashFontRenderParamsQuery(const FontRenderParamsQuery& query) {
FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
std::string* family_out) {
FontRenderParamsQuery actual_query(query);
- if (actual_query.device_scale_factor == 0) {
-#if defined(OS_CHROMEOS)
- actual_query.device_scale_factor = device_scale_factor_for_internal_display;
-#else
- // Linux does not support per-display DPI, so we use a slightly simpler
- // code path than on Chrome OS to figure out the device scale factor.
- gfx::Screen* screen = gfx::Screen::GetScreen();
- if (screen) {
- gfx::Display display = screen->GetPrimaryDisplay();
- actual_query.device_scale_factor = display.device_scale_factor();
- }
-#endif
- }
+ if (actual_query.device_scale_factor == 0)
+ actual_query.device_scale_factor = device_scale_factor_;
+
const uint32_t hash = HashFontRenderParamsQuery(actual_query);
SynchronizedCache* synchronized_cache = g_synchronized_cache.Pointer();
@@ -279,14 +265,12 @@ void ClearFontRenderParamsCacheForTest() {
synchronized_cache->cache.Clear();
}
-#if defined(OS_CHROMEOS)
float GetFontRenderParamsDeviceScaleFactor() {
- return device_scale_factor_for_internal_display;
+ return device_scale_factor_;
}
void SetFontRenderParamsDeviceScaleFactor(float device_scale_factor) {
- device_scale_factor_for_internal_display = device_scale_factor;
+ device_scale_factor_ = device_scale_factor;
}
-#endif
} // namespace gfx

Powered by Google App Engine
This is Rietveld 408576698