Fix a dependency issue in automake

Makefile.am

Index: Makefile.am
diff --git a/Makefile.am b/Makefile.am
index 8af3830e9ffae4a5d6a7a5a0f66a988f040141dc..9ca447ef08b64c0b476f5826d8d45abca9837957 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -524,6 +524,7 @@ endif
 src_client_linux_linux_client_unittest_shlib_DEPENDENCIES = \
 	src/client/linux/linux_dumper_unittest_helper \
 	src/client/linux/libbreakpad_client.a \
+	$(TEST_LIBS) \

[vapier, 2016/04/08 16:29:23]

pretty sure this is incorrect and incomplete:
- we already list $(TEST_LIBS) in LDADD for this target
- TEST_LIBS might be set to -l/-L values (see --enable-system-test-libs)
- this change should apply to all targets and not just this one

i think you'll want to add a new TEST_DEPENDENCIES variable and set it based on
SYSTEM_TEST_LIBS (see the common code around line 115 already) and then spread
that among the test targets

if SYSTEM_TEST_LIBS
TEST_LIBS = ...existing code...
TEST_DEPENDENCIES =
else
TEST_LIBS = ...should be blank now...
TEST_DEPENDENCIES = src/testing/libtesting.a
endif

[Ted Mielczarek, 2016/04/08 17:28:56]

Right, but as I said, since we're setting DEPENDENCIES here, they don't get
auto-generated from LDADD by automake. (Also I hate automake.)
Ah, I'll fix that.
The other targets should already work fine because we don't set DEPENDENCIES for
anything but this target.

 	src/libbreakpad.a
 
 src_client_linux_linux_client_unittest_SOURCES =