Fix a dependency issue in automake

Makefile.am

 ## Process this file with automake to produce Makefile.in
 
 # Copyright (c) 2011, Google Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
@@ skipping 506 matching lines @@
 if ANDROID_HOST
 src_client_linux_linux_client_unittest_shlib_SOURCES += \
         src/common/android/breakpad_getcontext_unittest.cc
 src_client_linux_linux_client_unittest_shlib_LDFLAGS += \
         -llog -lm
 endif
 
 src_client_linux_linux_client_unittest_shlib_DEPENDENCIES = \
         src/client/linux/linux_dumper_unittest_helper \
         src/client/linux/libbreakpad_client.a \
+        $(TEST_LIBS) \

[vapier, 2016/04/08 16:29:23]

pretty sure this is incorrect and incomplete:
- we already list $(TEST_LIBS) in LDADD for this target
- TEST_LIBS might be set to -l/-L values (see --enable-system-test-libs)
- this change should apply to all targets and not just this one

i think you'll want to add a new TEST_DEPENDENCIES variable and set it based on
SYSTEM_TEST_LIBS (see the common code around line 115 already) and then spread
that among the test targets

if SYSTEM_TEST_LIBS
TEST_LIBS = ...existing code...
TEST_DEPENDENCIES =
else
TEST_LIBS = ...should be blank now...
TEST_DEPENDENCIES = src/testing/libtesting.a
endif

[Ted Mielczarek, 2016/04/08 17:28:56]

Right, but as I said, since we're setting DEPENDENCIES here, they don't get
auto-generated from LDADD by automake. (Also I hate automake.)
Ah, I'll fix that.
The other targets should already work fine because we don't set DEPENDENCIES for
anything but this target.

         src/libbreakpad.a
 
 src_client_linux_linux_client_unittest_SOURCES =
 # The extra-long build id is for a test in minidump_writer_unittest.cc.
 src_client_linux_linux_client_unittest_LDFLAGS = \
         -Wl,-rpath,'$$ORIGIN' \
         -Wl,--build-id=0x000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f
 if ANDROID_HOST
 src_client_linux_linux_client_unittest_LDFLAGS += \
         -llog
@@ skipping 795 matching lines @@
         src/tools/windows/dump_syms/dump_syms.vcproj \
         src/tools/windows/dump_syms/run_regtest.sh \
         src/tools/windows/dump_syms/testdata/dump_syms_regtest.cc \
         src/tools/windows/dump_syms/testdata/dump_syms_regtest.pdb \
         src/tools/windows/dump_syms/testdata/dump_syms_regtest.sym \
         src/tools/windows/symupload/symupload.cc \
         src/tools/windows/symupload/symupload.vcproj
 
 mostlyclean-local:
         -find src -name '*.dwo' -exec rm -f {} +