Fix a dependency issue in automake

Fix a dependency issue in automake

Doing a `make -jN check` from a fresh build breaks (and has probably been
broken for a while). linux_client_unittest_shlib is missing $(TEST_LIBS)
from its _DEPENDENCIES. The automake manual says if _DEPENDENCIES are not
specified they'll be computed from _LDADD, but we are specifying it and just
leaving out $(TEST_LIBS).

R=vapier@chromium.org
BUG=

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/205b5ac6edd63988309290ac15e69775f3b3f564

[Ted Mielczarek, 2016-04-08 14:27:01]

...and with this patch, I finally have a green build on travis-ci:
https://travis-ci.org/luser/breakpad

Pretty trivial patch:
https://github.com/luser/breakpad/commit/5666beaf0110075496e66a9b5696dfe9975f...

[vapier, 2016-04-08 16:29:23]

https://codereview.chromium.org/1870733005/diff/1/Makefile.am
File Makefile.am (right):

https://codereview.chromium.org/1870733005/diff/1/Makefile.am#newcode527
Makefile.am:527: $(TEST_LIBS) \
pretty sure this is incorrect and incomplete:
- we already list $(TEST_LIBS) in LDADD for this target
- TEST_LIBS might be set to -l/-L values (see --enable-system-test-libs)
- this change should apply to all targets and not just this one

i think you'll want to add a new TEST_DEPENDENCIES variable and set it based on
SYSTEM_TEST_LIBS (see the common code around line 115 already) and then spread
that among the test targets

if SYSTEM_TEST_LIBS
TEST_LIBS = ...existing code...
TEST_DEPENDENCIES =
else
TEST_LIBS = ...should be blank now...
TEST_DEPENDENCIES = src/testing/libtesting.a
endif

[Ted Mielczarek, 2016-04-08 17:28:56]

https://codereview.chromium.org/1870733005/diff/1/Makefile.am
File Makefile.am (right):

https://codereview.chromium.org/1870733005/diff/1/Makefile.am#newcode527
Makefile.am:527: $(TEST_LIBS) \
On 2016/04/08 16:29:23, vapier wrote:
> pretty sure this is incorrect and incomplete:
> - we already list $(TEST_LIBS) in LDADD for this target

Right, but as I said, since we're setting DEPENDENCIES here, they don't get
auto-generated from LDADD by automake. (Also I hate automake.)

> - TEST_LIBS might be set to -l/-L values (see --enable-system-test-libs)

Ah, I'll fix that.

> - this change should apply to all targets and not just this one

The other targets should already work fine because we don't set DEPENDENCIES for
anything but this target.

[Ted Mielczarek, 2016-04-12 10:04:35]

Review ping?

[vapier, 2016-04-12 17:14:17]

lgtm

[Ted Mielczarek, 2016-04-12 18:55:21]

Description was changed from

==========
Fix a dependency issue in automake

Doing a `make -jN check` from a fresh build breaks (and has probably been
broken for a while). linux_client_unittest_shlib is missing $(TEST_LIBS)
from its _DEPENDENCIES. The automake manual says if _DEPENDENCIES are not
specified they'll be computed from _LDADD, but we are specifying it and just
leaving out $(TEST_LIBS).

R=vapier@chromium.org
BUG=
==========

to

==========
Fix a dependency issue in automake

Doing a `make -jN check` from a fresh build breaks (and has probably been
broken for a while). linux_client_unittest_shlib is missing $(TEST_LIBS)
from its _DEPENDENCIES. The automake manual says if _DEPENDENCIES are not
specified they'll be computed from _LDADD, but we are specifying it and just
leaving out $(TEST_LIBS).

R=vapier@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/205b5ac6edd63988309290a...
==========

[Ted Mielczarek, 2016-04-12 18:55:24]

Committed patchset #2 (id:20001) manually as
205b5ac6edd63988309290ac15e69775f3b3f564 (presubmit successful).