[css-grid] Fix positioned items with content alignment

[css-grid] Fix positioned items with content alignment

Like for the case of gaps we need to take into account
the content alignment in order to properly place and size
the positioned items.

Regarding content alignment we need to care about 2 values:
the position offset and the distribution offset.
The position offset can be extracted from m_column|rowPositions,
but the distribution offset is stored in 2 new variables called
m_offsetBetweenColumns|Rows.

Added new tests checking the right behavior.

BUG=566265
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment.html
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment-rtl.html

Committed: https://crrev.com/506951c7c67fda272ac85ed9f195c79f1c691ae9
Cr-Commit-Position: refs/heads/master@{#386952}

[Manuel Rego, 2016-04-07 07:30:16]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[cbiesinger, 2016-04-12 20:46:39]

lgtm

https://codereview.chromium.org/1870623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1870623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1548: LayoutUnit
alignmentOffset =  isForColumns ? m_columnPositions[0] - borderAndPaddingStart()
: m_rowPositions[0] - borderAndPaddingBefore();
two spaces after the equal sign here, remove one

[Manuel Rego, 2016-04-13 08:13:22]

Thanks for the review.

https://codereview.chromium.org/1870623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutGrid.cpp (right):

https://codereview.chromium.org/1870623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutGrid.cpp:1548: LayoutUnit
alignmentOffset =  isForColumns ? m_columnPositions[0] - borderAndPaddingStart()
: m_rowPositions[0] - borderAndPaddingBefore();
On 2016/04/12 20:46:39, cbiesinger wrote:
> two spaces after the equal sign here, remove one

Done.

Actually I had 2 spaces in a few more places (dunno why). :-)

[Manuel Rego, 2016-04-13 08:13:28]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-04-13 08:13:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1870623002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-04-13 08:13:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870623002/20001

[commit-bot: I haz the power, 2016-04-13 09:46:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 09:48:14]

Description was changed from

==========
[css-grid] Fix positioned items with content alignment

Like for the case of gaps we need to take into account
the content alignment in order to properly place and size
the positioned items.

Regarding content alignment we need to care about 2 values:
the position offset and the distribution offset.
The position offset can be extracted from m_column|rowPositions,
but the distribution offset is stored in 2 new variables called
m_offsetBetweenColumns|Rows.

Added new tests checking the right behavior.

BUG=566265
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment.html
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment-rtl.html
==========

to

==========
[css-grid] Fix positioned items with content alignment

Like for the case of gaps we need to take into account
the content alignment in order to properly place and size
the positioned items.

Regarding content alignment we need to care about 2 values:
the position offset and the distribution offset.
The position offset can be extracted from m_column|rowPositions,
but the distribution offset is stored in 2 new variables called
m_offsetBetweenColumns|Rows.

Added new tests checking the right behavior.

BUG=566265
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment.html
TEST=fast/css-grid-layout/grid-positioned-items-content-alignment-rtl.html

Committed: https://crrev.com/506951c7c67fda272ac85ed9f195c79f1c691ae9
Cr-Commit-Position: refs/heads/master@{#386952}
==========

[commit-bot: I haz the power, 2016-04-13 09:48:15]

Patchset 2 (id:??) landed as
https://crrev.com/506951c7c67fda272ac85ed9f195c79f1c691ae9
Cr-Commit-Position: refs/heads/master@{#386952}