Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1870603002: Make VTTParserClient the GC mixin it needs to be. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, Nate Chapin, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VTTParserClient the GC mixin it needs to be. Unsafe for the VTTParser to keep a raw pointer to the GCed object implementing this client interface. R=haraken BUG= Committed: https://crrev.com/ef5d078caf070abc857a90463435499896c93a83 Cr-Commit-Position: refs/heads/master@{#385688}

Patch Set 1 #

Patch Set 2 : tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-07 06:28:24 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-07 07:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870603002/20001
4 years, 8 months ago (2016-04-07 07:33:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 07:37:58 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 07:39:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef5d078caf070abc857a90463435499896c93a83
Cr-Commit-Position: refs/heads/master@{#385688}

Powered by Google App Engine
This is Rietveld 408576698