Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTParser.h

Issue 1870603002: Make VTTParserClient the GC mixin it needs to be. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tidying Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
index ae9b24d4a84e31d93dce45314f79f6358104eac4..262d001ef23a5addbfbeea255cce9450999aa9ef 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTParser.h
@@ -47,13 +47,15 @@ namespace blink {
class Document;
class VTTScanner;
-class VTTParserClient {
+class VTTParserClient : public GarbageCollectedMixin {
public:
virtual ~VTTParserClient() { }
virtual void newCuesParsed() = 0;
virtual void newRegionsParsed() = 0;
virtual void fileFailedToParse() = 0;
+
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
};
class VTTParser final : public GarbageCollectedFinalized<VTTParser> {
@@ -144,7 +146,7 @@ private:
StringBuilder m_currentContent;
String m_currentSettings;
- VTTParserClient* m_client;
+ Member<VTTParserClient> m_client;
HeapVector<Member<TextTrackCue>> m_cueList;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698