Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, add more comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
index d185894ade76ac4ea93c0167e11923c7c1e281a1..7a8e8aff63eb1b46991fbfb72d793f34f692626b 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt
@@ -51,6 +51,13 @@ New Procedures and Functions
INVALID_ENUM is generated if <usage> is not READ_WRTIE_CHROMIUM.
+ On OS X, driver bugs prevent the usage of memory buffers with RGB internal
+ format. As a workaround, the created GpuMemoryBuffer will always have
+ internal format RGBA. The caller is responsible for handling this
+ appropriately. The only support provided by this extension is that calls to
+ copyTexImage2D and copyTexSubImage2D will perform paramter validation as if
+ the internal format were RGB.
piman 2016/04/14 01:05:43 How is the client supposed to know? Does this mean
piman 2016/04/14 01:05:43 Actually, it looks like ReadPixels is affected too
erikchen 2016/04/14 01:20:10 For reference, this is the companion CL that imple
erikchen 2016/04/14 21:24:46 I started adding a capability, but I couldn't find
+
Errors
None.
@@ -62,3 +69,4 @@ New State
Revision History
9/29/2014 Documented the extension.
+ 4/12/2016 Added details of OS X RGB workaround.
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | gpu/command_buffer/service/texture_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698