gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt - Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation.

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_gpu_memory_buffer_image.txt

Issue 1870483003: Add command buffer support for GL_RGB CHROMIUM image emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, add more comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_gpu_memory_buffer_image	3 CHROMIUM_gpu_memory_buffer_image

4	4

5 Name Strings	5 Name Strings

6	6

7 GL_CHROMIUM_gpu_memory_buffer_image	7 GL_CHROMIUM_gpu_memory_buffer_image

8	8

9 Version	9 Version

10	10

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 Returns a unique identifier for the image that could be used in	44 Returns a unique identifier for the image that could be used in

45 subsequent operations.	45 subsequent operations.

46	46

47 INVALID_VALUE is generated if <width> or <height> is nonpositive.	47 INVALID_VALUE is generated if <width> or <height> is nonpositive.

48	48

49 INVALID_ENUM is generated if <internalformat> is not one of	49 INVALID_ENUM is generated if <internalformat> is not one of

50 RGB or RGBA.	50 RGB or RGBA.

51	51

52 INVALID_ENUM is generated if <usage> is not READ_WRTIE_CHROMIUM.	52 INVALID_ENUM is generated if <usage> is not READ_WRTIE_CHROMIUM.

53	53

	54 On OS X, driver bugs prevent the usage of memory buffers with RGB internal

	55 format. As a workaround, the created GpuMemoryBuffer will always have

	56 internal format RGBA. The caller is responsible for handling this

	57 appropriately. The only support provided by this extension is that calls to

	58 copyTexImage2D and copyTexSubImage2D will perform paramter validation as if

	59 the internal format were RGB.
	piman 2016/04/14 01:05:43 How is the client supposed to know? Does this mean How is the client supposed to know? Does this mean we'll have #ifdefs OS_MACOSX to deal with this? Can we instead at least add a cap bit (in gpu::Capabilities) / extension string to explain when the workaround is in place? piman 2016/04/14 01:05:43 Actually, it looks like ReadPixels is affected too Actually, it looks like ReadPixels is affected too. erikchen 2016/04/14 01:20:10 For reference, this is the companion CL that imple Show quoted text On 2016/04/14 01:05:43, piman wrote: > Actually, it looks like ReadPixels is affected too. For reference, this is the companion CL that implements the client side workaround: https://codereview.chromium.org/1856933002/ There's already an #ifdef OS_MACOSX, because the target needs to be RECTANGLE instead of 2D. If you want, we could expose 2 capabilities, one for RGB workaround, and one for RECTANGLE instead of 2D, and then we could remove the #ifdef from DrawingBuffer.cpp erikchen 2016/04/14 21:24:46 I started adding a capability, but I couldn't find Show quoted text On 2016/04/14 01:20:10, erikchen wrote: > On 2016/04/14 01:05:43, piman wrote: > > Actually, it looks like ReadPixels is affected too. > > For reference, this is the companion CL that implements the client side > workaround: > https://codereview.chromium.org/1856933002/ > > There's already an #ifdef OS_MACOSX, because the target needs to be RECTANGLE > instead of 2D. If you want, we could expose 2 capabilities, one for RGB > workaround, and one for RECTANGLE instead of 2D, and then we could remove the > #ifdef from DrawingBuffer.cpp I started adding a capability, but I couldn't find a good mechanism for passing capabilities through to WebKit. Right now, most flags that alter behavior get passed in during WebKit initialization in the form of WebRuntimeFeatures. I guess we could add a new public API, or somehow expose the capability through OpenGL interface, but neither of those sounds very appealing, given that all we're really doing is plumbing an #ifdef from gpu/command_buffer/service to WebKit. Or maybe I missed an existing mechanism for passing this information?
	60

54 Errors	61 Errors

55	62

56 None.	63 None.

57	64

58 New State	65 New State

59	66

60 None.	67 None.

61	68

62 Revision History	69 Revision History

63	70

64 9/29/2014 Documented the extension.	71 9/29/2014 Documented the extension.

	72 4/12/2016 Added details of OS X RGB workaround.

OLD	NEW

« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | gpu/command_buffer/service/texture_manager.cc » ('J')