Improve elements validation and object printing

Improve elements validation and object printing

Make sure we check that packed elements do not containt TheHole.
%DebugPrint:
- Only print the transition arrays for maps
- Print more detailed instance types directly for objects
- directly print the array length for JS_ARRAY objects

BUG=

Committed: https://crrev.com/9285ac92ace7f4d1fb42c5ab502513d4cde7d71d
Cr-Commit-Position: refs/heads/master@{#35338}

[Camillo Bruni, 2016-04-07 11:51:40]

cbruni@chromium.org changed reviewers:
+ verwaest@chromium.org

[Camillo Bruni, 2016-04-07 11:51:41]

PTAL

[Toon Verwaest, 2016-04-07 13:01:39]

lgtm

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc#newcode...
src/elements.cc:1582: DCHECK(map != heap->fixed_cow_array_map());
DCHECK_NE Would already be included in the suggested check below.

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc#newcode...
src/elements.cc:1583: if (map == heap->fixed_array_map()) DCHECK_EQ(0, length);
DCHECK(map == fixed_double_array_map() ||
       (map == fixed_array_map() && 0 == length)); ?

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc#newcode...
src/elements.cc:1598: for (int i = 0; i < length; i++) {
This probably should be SLOW_ASSERTS

[Camillo Bruni, 2016-04-07 13:12:38]

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc#newcode...
src/elements.cc:1583: if (map == heap->fixed_array_map()) DCHECK_EQ(0, length);
On 2016/04/07 at 13:01:39, Toon Verwaest wrote:
> DCHECK(map == fixed_double_array_map() ||
>        (map == fixed_array_map() && 0 == length)); ?

I prefer the separate checks, makes it easier for debugging and adding more
checks.

https://codereview.chromium.org/1870433003/diff/40001/src/elements.cc#newcode...
src/elements.cc:1598: for (int i = 0; i < length; i++) {
On 2016/04/07 at 13:01:39, Toon Verwaest wrote:
> This probably should be SLOW_ASSERTS

yup

[Camillo Bruni, 2016-04-07 14:53:13]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-04-07 14:53:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1870433003/#ps60001
(title: "addressing nits")

[commit-bot: I haz the power, 2016-04-07 14:53:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870433003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870433003/60001

[commit-bot: I haz the power, 2016-04-07 15:27:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 15:29:19]

Description was changed from

==========
Improve elements validation and object printing

Make sure we check that packed elements do not containt TheHole.
%DebugPrint:
- Only print the transition arrays for maps
- Print more detailed instance types directly for objects
- directly print the array length for JS_ARRAY objects

BUG=
==========

to

==========
Improve elements validation and object printing

Make sure we check that packed elements do not containt TheHole.
%DebugPrint:
- Only print the transition arrays for maps
- Print more detailed instance types directly for objects
- directly print the array length for JS_ARRAY objects

BUG=

Committed: https://crrev.com/9285ac92ace7f4d1fb42c5ab502513d4cde7d71d
Cr-Commit-Position: refs/heads/master@{#35338}
==========

[commit-bot: I haz the power, 2016-04-07 15:29:20]

Patchset 4 (id:??) landed as
https://crrev.com/9285ac92ace7f4d1fb42c5ab502513d4cde7d71d
Cr-Commit-Position: refs/heads/master@{#35338}