src/objects-inl.h - Issue 1870433003: Improve elements validation and object printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1870433003: Improve elements validation and object printing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressing nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index e1a44e746106e5aebd5b4819b08cd542c4f4ccdd..bea0ad3d5124283416dcfb11fba27e9578a5064d 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1779,7 +1779,7 @@ void JSObject::EnsureCanContainElements(Handle<JSObject> object,

Object** objects,

uint32_t count,

EnsureElementsMode mode) {

- ElementsKind current_kind = object->map()->elements_kind();

+ ElementsKind current_kind = object->GetElementsKind();

ElementsKind target_kind = current_kind;

{

DisallowHeapAllocation no_allocation;

« no previous file with comments | « src/elements.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »