Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1870233002: Convert crypto to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
sdefresne, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert crypto to std::unique_ptr BUG=554298 TBR=sdefresne Committed: https://crrev.com/d1a1847163c0038284a7053b41ba0dedfad9b7b7 Cr-Commit-Position: refs/heads/master@{#386228}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -155 lines) Patch
M chrome/browser/internal_auth.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nacl_validation_query_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_calculator.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M crypto/ec_private_key_nss.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M crypto/ec_private_key_unittest.cc View 9 chunks +15 lines, -12 lines 0 comments Download
M crypto/ec_signature_creator_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M crypto/encryptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/encryptor_unittest.cc View 12 chunks +30 lines, -30 lines 0 comments Download
M crypto/hkdf.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/hmac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/hmac.cc View 2 chunks +2 lines, -1 line 0 comments Download
M crypto/hmac_nss.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M crypto/hmac_openssl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M crypto/nss_key_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M crypto/nss_util.cc View 8 chunks +12 lines, -8 lines 0 comments Download
M crypto/rsa_private_key_nss.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M crypto/rsa_private_key_openssl.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M crypto/rsa_private_key_unittest.cc View 9 chunks +15 lines, -14 lines 0 comments Download
M crypto/scoped_nss_types.h View 2 chunks +20 lines, -16 lines 0 comments Download
M crypto/scoped_openssl_types.h View 3 chunks +3 lines, -3 lines 0 comments Download
M crypto/scoped_test_system_nss_key_slot.h View 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/secure_hash_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M crypto/sha2.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M crypto/signature_creator_nss.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/signature_creator_openssl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M crypto/signature_creator_unittest.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M crypto/signature_verifier_openssl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M crypto/symmetric_key_openssl.cc View 1 2 3 4 5 6 7 4 chunks +4 lines, -4 lines 0 comments Download
M crypto/symmetric_key_unittest.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M crypto/symmetric_key_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/android/keystore_openssl.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/jwk_serializer_nss.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M net/cert/nss_cert_database.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Nico
4 years, 8 months ago (2016-04-08 21:10:36 UTC) #2
Ryan Sleevi
LGTM with one (unfortunate) nit https://codereview.chromium.org/1870233002/diff/120001/crypto/symmetric_key_openssl.cc File crypto/symmetric_key_openssl.cc (right): https://codereview.chromium.org/1870233002/diff/120001/crypto/symmetric_key_openssl.cc#newcode16 crypto/symmetric_key_openssl.cc:16: #include "crypto/symmetric_key.h" This shouldn't ...
4 years, 8 months ago (2016-04-08 21:15:26 UTC) #3
Nico
thanks! https://codereview.chromium.org/1870233002/diff/120001/crypto/symmetric_key_openssl.cc File crypto/symmetric_key_openssl.cc (right): https://codereview.chromium.org/1870233002/diff/120001/crypto/symmetric_key_openssl.cc#newcode16 crypto/symmetric_key_openssl.cc:16: #include "crypto/symmetric_key.h" On 2016/04/08 21:15:26, Ryan Sleevi wrote: ...
4 years, 8 months ago (2016-04-08 21:20:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1870233002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1870233002/140001
4 years, 8 months ago (2016-04-08 21:21:35 UTC) #8
Nico
tbr sdefresne for components/owners
4 years, 8 months ago (2016-04-08 21:21:44 UTC) #10
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 8 months ago (2016-04-08 22:30:55 UTC) #12
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/d1a1847163c0038284a7053b41ba0dedfad9b7b7 Cr-Commit-Position: refs/heads/master@{#386228}
4 years, 8 months ago (2016-04-08 22:32:05 UTC) #14
sdefresne
4 years, 8 months ago (2016-04-09 13:27:24 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698