Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 187023002: Manual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf regression. (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/image/SkSurface_Gpu.cpp View 1 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 9 months ago (2014-03-04 21:14:36 UTC) #1
reed1
lgtm https://codereview.chromium.org/187023002/diff/1/src/image/SkSurface_Gpu.cpp File src/image/SkSurface_Gpu.cpp (right): https://codereview.chromium.org/187023002/diff/1/src/image/SkSurface_Gpu.cpp#newcode75 src/image/SkSurface_Gpu.cpp:75: SkGpuDevice* newDevice = static_cast<SkGpuDevice*>( LEts add a comment ...
6 years, 9 months ago (2014-03-04 22:01:05 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-04 22:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/187023002/20001
6 years, 9 months ago (2014-03-04 22:21:22 UTC) #4
bsalomon
https://codereview.chromium.org/187023002/diff/1/src/image/SkSurface_Gpu.cpp File src/image/SkSurface_Gpu.cpp (right): https://codereview.chromium.org/187023002/diff/1/src/image/SkSurface_Gpu.cpp#newcode75 src/image/SkSurface_Gpu.cpp:75: SkGpuDevice* newDevice = static_cast<SkGpuDevice*>( On 2014/03/04 22:01:05, reed1 wrote: ...
6 years, 9 months ago (2014-03-04 22:22:13 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 22:37:32 UTC) #6
Message was sent while issue was closed.
Change committed as 13662

Powered by Google App Engine
This is Rietveld 408576698